[Draft] Fix BIRPackage.importModules containing duplicate elements
#42346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thushara-Piyasekara
requested review from
sameerajayasoma and
hasithaa
as code owners
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRNode.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dedup-birpkg-imports #42346 +/- ##
==========================================================
+ Coverage 76.50% 78.07% +1.56%
- Complexity 53177 58685 +5508
==========================================================
Files 2892 3492 +600
Lines 201001 232268 +31267
Branches 26189 32768 +6579
==========================================================
+ Hits 153776 181336 +27560
- Misses 38765 41432 +2667
- Partials 8460 9500 +1040 ☔ View full report in Codecov by Sentry. |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
gimantha
changed the title
BIRPackage.importModules containing duplicate elementsBIRPackage.importModules containing duplicate elements
gimantha
merged commit 90b8860
into
ballerina-platform:dedup-birpkg-imports
29 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #42343
Approach
Restricted the addition of duplicate elements by the usage of a HashSet instead of an ArrayList and setting up the necessary
equals()andhashCode()functions for theBIRImportModuleclass. This will filter the duplicate imports after the BIR Gen phase.Samples
Remarks
The root cause of the duplicate imports is in the AST level. The duplicate imports originally derive from the
importstatements in.balfiles. Since a ballerina project can have more than one.balfile it produces more than oneBLangImportPackage.These AST level imports are used by the DataflowAnalyzer to detect unused imports. Therefore duplicates are needed in AST level.
Due to above reasoning, the safe choice is to omit them during the BIR Gen phase.
Check List